add support for key exporters - #310
Draft
marten-seemann wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #310 +/- ##
==========================================
+ Coverage 81.66% 81.87% +0.20%
==========================================
Files 10 10
Lines 1342 1357 +15
==========================================
+ Hits 1096 1111 +15
Misses 172 172
Partials 74 74 ☔ View full report in Codecov by Harness. |
|
The Firefox side has landed, so this should be unblocked.
One heads-up: the API recently followed a spec change (args are now required, plus an //CC @jesup since this is your work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115.
Waiting for @mxinden to cut a new Neqo release that includes mozilla/neqo#3464, so we can test with Firefox Nightly.
Note
Add
Session.ExportKeyingMaterialfor TLS keying material exportExportKeyingMaterialonSessionin session.go, which derives keying material via the TLS exporter using the label"EXPORTER-WebTransport"and a constructed context containing the session ID, label, and context bytes.Macroscope summarized 5a264bd.